Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains multiple fixes and updates:
nodejs18:1-60
comes with a version that doesn't work with thelatest
version of npm. So it will be updated to the newer versionnodejs-18:1-71.1698060565
too many open files
error in npm. Because new image now features limits set in them, aulimit
override flag was added topodman build
plugin-manifest.json
, unless new flag--update-manifest
is set.It should make for a better developers workflow. who while trying to build these plugins locally would rather not want to create & commit changes to manifest, as only the Jenkins job should do it, when it builds them after merges to main branch.--clean
flag is updated, instead of doing system prune, it would just remove the final builder image, and base layer images won't have to be redownloaded, when developers/Jenkins are building more than 1 plugin.project-config.json
with newer revisions, that were not reachable anymorethis PR has to be merged in conjunction with another DS Jenkins PR https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/merge_requests/1746