Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CRW-4859 fix extension builds #77

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

mkuznyetsov
Copy link
Contributor

@mkuznyetsov mkuznyetsov commented Nov 4, 2023

This PR contains multiple fixes and updates:

  • update README.md with relevant information about the project
  • added archives to .gitignore.
  • most of extensions were not buildable, because current ubi8image nodejs18:1-60 comes with a version that doesn't work with the latest version of npm. So it will be updated to the newer version nodejs-18:1-71.1698060565
  • with that, some more extensions started to fail their build on newer image, because of too many open files error in npm. Because new image now features limits set in them, a ulimit override flag was added to podman build
  • build.sh script will not update manifests in plugin-manifest.json, unless new flag --update-manifest is set.It should make for a better developers workflow. who while trying to build these plugins locally would rather not want to create & commit changes to manifest, as only the Jenkins job should do it, when it builds them after merges to main branch.
  • buiild.sh script --clean flag is updated, instead of doing system prune, it would just remove the final builder image, and base layer images won't have to be redownloaded, when developers/Jenkins are building more than 1 plugin.
  • update project-config.json with newer revisions, that were not reachable anymore

this PR has to be merged in conjunction with another DS Jenkins PR https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/merge_requests/1746

Copy link

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, though I have a few comments about mixing upstream and downstream work here. A few suggestions on that front (though if this PR is needed soon we can merge as-is and discuss later). Nevermind, I had it in my head that this was a Che repository :)

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@mkuznyetsov mkuznyetsov merged commit c5b0795 into devspaces-3-rhel-8 Nov 22, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants