Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't add lombok.jar into UDI #392

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

svor
Copy link
Contributor

@svor svor commented Jan 16, 2023

Signed-off-by: Valerii Svydenko [email protected]

Since VSCode redhat.java extension doesn't require the path to lombok.jar we can avoid adding lombok.jar into UDI

Related issue: https://issues.redhat.com/browse/CRW-3602

@svor svor requested a review from nickboldt January 16, 2023 17:35
@svor svor self-assigned this Jan 16, 2023
@svor
Copy link
Contributor Author

svor commented Jan 16, 2023

@nickboldt I've removed fetch-artifacts-pnc.yaml, should I do additional cleanup somewhere?

@nickboldt
Copy link
Member

nickboldt commented Jan 16, 2023

Seems reasonable but I would not merge this until we know FOR SURE that we'll be dropping theia from the 3.6 payload.

@Kasturi1820 FYI, this is one of the several changes that will be queued to include in 3.6 which we can't merge until we 💯 decide when Theia goes away.

@nickboldt
Copy link
Member

should I do additional cleanup somewhere?

I think you've done all that's needed:

  • don't fetch the jar in yaml
  • don't use the jar in dockerfile

@nickboldt nickboldt mentioned this pull request Mar 8, 2023
45 tasks
@nickboldt nickboldt merged commit e95eb76 into devspaces-3-rhel-8 Mar 8, 2023
@nickboldt nickboldt deleted the sv-CRW-3602 branch March 8, 2023 18:54
@devstudio-release
Copy link
Contributor

Build 3.6 :: udi_3.x/221: Console, Changes, Git Data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants