Skip to content
This repository has been archived by the owner on Nov 10, 2021. It is now read-only.

DEVELOPER-4290 - Mike updated the product title #1940

Merged
merged 2 commits into from
Jul 11, 2017

Conversation

LightGuard
Copy link
Member

Mike updated the title on the product and would like the link in the technology menu to match the title of the product.

Mike updated the title on the product and would like the link in the technology menu to match the title of the product.
@LightGuard
Copy link
Member Author

@KamiQuasi feel free to merge whenever you're ready. This only changes the text in the Technologies menu for the .NET product.

@robpblake
Copy link
Contributor

@LightGuard The tests will need updating to reflect the new menu item.

cheers,

Rob

@ianrhamilton
Copy link
Contributor

@LightGuard Is there any want we can hit a drupal end point to test product existence rather than hard-code them? I'd like to avoid hard coding products when I begin refactoring the tests.

@LightGuard
Copy link
Member Author

Not currently.

I hope this gets them all.
@LightGuard LightGuard changed the title Mike updated the product title DEVELOPER-4290 - Mike updated the product title Jul 7, 2017
@LightGuard
Copy link
Member Author

retest this please

@LightGuard LightGuard closed this Jul 7, 2017
@LightGuard LightGuard reopened this Jul 7, 2017
@LightGuard
Copy link
Member Author

retest this please

1 similar comment
@ianrhamilton
Copy link
Contributor

retest this please

@KamiQuasi
Copy link
Contributor

@RubyGemTSL I think the test that is failing is due to the page not being updated. Not sure it will pass until that happens. Should we go ahead and merge, and then update Prod Drupal with the change?

@ianrhamilton
Copy link
Contributor

@KamiQuasi yes let's do that. I want to get rid of hard coding products in tests. When we get the REST endpoint we can avoid these issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants