WIP Initial api server #1
Conversation
deploy/grant-cluster-admin.yaml
Outdated
| subjects: | ||
| - kind: ServiceAccount | ||
| name: apiserver | ||
| namespace: codeready-devconsole |
There was a problem hiding this comment.
Let's use the openshift-devops-console namespace ( along the lines of openshift-web-console )
alexeykazakov
requested review from
sbryzak,
xcoulon,
dipak-pawar and
MatousJobanek
deploy/replication_controller.yaml
Outdated
| @@ -0,0 +1,38 @@ | |||
| apiVersion: v1 | |||
| kind: ReplicationController | |||
There was a problem hiding this comment.
How about Deployment? we'll get same functionality of RC, along with rollout/rollback using ReplicaSet?
There was a problem hiding this comment.
Yeah we can switch to Deployment. But maybe in a followup PR?
There was a problem hiding this comment.
deploy/service_account.yaml
Outdated
| kind: ServiceAccount | ||
| apiVersion: v1 | ||
| metadata: | ||
| name: apiserver |
There was a problem hiding this comment.
| @@ -0,0 +1,88 @@ | |||
| DOCKER_REPO?=quay.io/openshiftio | |||
There was a problem hiding this comment.
I think we should get rid out of openshiftio
There was a problem hiding this comment.
Yes, but we do not have any better repo yet. Will switch to something more suitable later.
| @@ -0,0 +1,38 @@ | |||
| apiVersion: v1 | |||
| kind: ReplicationController | |||
There was a problem hiding this comment.
How about Deployment? we'll get same functionality of RC, along with rollout/rollback using ReplicaSet?
There was a problem hiding this comment.
deploy/replication_controller.yaml
Outdated
| # Replace this with the built image name | ||
| image: REPLACE_IMAGE | ||
| imagePullPolicy: Always | ||
| command: [ "/git-service", "--etcd-servers=http://localhost:2379" ] |
There was a problem hiding this comment.
just curious, did we verify that etcd servers have valid certificates to talk using localhost on openshift 4. Also we need to figure out how can we get HA node etcd clusters endpoints?
There was a problem hiding this comment.
I'm not sure we really care about that right now. We do not manipulate any resources (at least not yet). Will need to look at this later if needed.
| containers: | ||
| - name: git-service | ||
| # Replace this with the built image name | ||
| image: quay.io/openshiftio/git-service:dev |
There was a problem hiding this comment.
Yes. But not now :) See above.
pkg/apiserver/apiserver.go
Outdated
|
|
||
| func installCompositionGitWebService(gitServer *GitAPIServer) { | ||
| path := fmt.Sprintf("/apis/%s/%s/namespaces/{namespace}", GroupName, GroupVersion) | ||
| fmt.Println("WS PATH:" + path) |
There was a problem hiding this comment.
| @@ -0,0 +1,19 @@ | |||
| FROM quay.io/openshiftio/rhel-base-golang:latest | |||
There was a problem hiding this comment.
maybe we should start using multi-stage docker build https://docs.docker.com/develop/develop-images/multistage-build/
There was a problem hiding this comment.
@dipak-pawar it was not supported in OpenShift 3 because the version of the supported Docker daemon was too old. I'm not sure about OpenShift 4, though. Maybe it could work with Buildah ?
|
|
||
|
|
||
| [[constraint]] | ||
| branch = "master" |
There was a problem hiding this comment.
We should probably lock these down later on, but I think it's fine to leave them as is for now.
This is just an initial commit with Shane's POC (https://github.com/sbryzak/kubepoc) + makefile + minishift wiring + other infra changes + some cleanup.
I would like to merge it sooner rather than blowing it up by trying to make it perfect in the first shot.
Our next steps/PR would be: