Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mono core #22

Merged
merged 13 commits into from
Dec 16, 2022
Merged

Mono core #22

merged 13 commits into from
Dec 16, 2022

Conversation

jackdelahunt
Copy link
Collaborator

@jackdelahunt jackdelahunt commented Nov 29, 2022 •
edited
Loading

This PR adds the work completed from my fork with some cleaning up. It adds the go and js SDK in the repo acting as a mono repo.

There are a lot of changes so the main places to take a look are:

  • changes in the .github/workflows directory
  • changes in the scripts directory

@jackdelahunt jackdelahunt force-pushed the mono-core branch 3 times, most recently from a1b005b to 30ce5dd Compare November 29, 2022 11:47
@jackdelahunt jackdelahunt requested a review from dimakis November 29, 2022 11:52
dimakis
dimakis approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this PR is huge, I've tried to have a look at the relevant bits and from what I've seen it looks good. We will get more of an insight into it when its merged and tested.

great work @jackdelahunt

@jackdelahunt
Copy link
Collaborator Author

Cool will merge when other pr is merged into this 👍

dimakis
dimakis reviewed Dec 7, 2022
View reviewed changes
Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest it is very difficult to keep up with what is going on with the amount of files added.
maybe we can sync and you can walk me though it?

.github/workflows/generate-sdks.yaml Show resolved Hide resolved
dimakis
dimakis reviewed Dec 8, 2022
View reviewed changes
.github/workflows/api-update.yaml Show resolved Hide resolved
.github/workflows/publish.yaml Show resolved Hide resolved
.github/workflows/publish.yaml
yarn install
yarn build
- name: Inject slug/short variables
uses: rlespinasse/github-slug-action@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be worth trying each release with your own npm / pypi etc. account from this dir structure to ensure the paths are correct

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after this pr but before we update the openapi generator version

dimakis
dimakis approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these paths for the .md files are correct. Not aware of any that have been missed but we can cross that bridge if it happens.

Great work on this @jackdelahunt

@dimakis dimakis merged commit 7619dbe into main Dec 16, 2022
@dimakis dimakis mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimakis dimakis dimakis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackdelahunt @dimakis @app-services-ci