feat: added a timeout to the login command

[alexal]

Closes #989

[alexal]

@craicoverflow have you had a chance to review the changes?

[craicoverflow]

The build is failing - this needs to be fixed.

@craicoverflow have you had a chance to review the changes?

We have a number of tasks to complete, but don't worry - this is on the backlog.

[craicoverflow]

So, the best way to do this would be to use context.WithTimeout, but only on the auth requests.

I believe that the timeout should be focused on the network request, not the command itself.

Currently we are using context.WithCancel here, this could be replaced with context.WithTimeout.

Since one context is created for each OpenID client, using 30 seconds for each might be satisfactory (as when combined it gives 60 seconds) - looking for @wtrocki's opinion before we agree with this approach.

[wtrocki]

So first callback requires human interaction (if you need to login). Second callback uses SSO so it is almost instant.
I like global timeout but if we want to go with individual ones it should be 60 for first and 10 seconds for second.

[craicoverflow]

So first callback requires human interaction (if you need to login). Second callback uses SSO so it is almost instant.
I like global timeout but if we want to go with individual ones it should be 60 for first and 10 seconds for second.

Global timeout makes sense then. We should try to avail of the built-in context.WithTimeout for this then.

The context can be passed to login.Execute(ctx) from the login command:

app-services-cli/pkg/auth/login/login.go

Line 41 in b4128d5

func (a *AuthorizationCodeGrant) Execute(ctx context.Context, ssoCfg *SSOConfig, masSSOCfg *SSOConfig) error {

[craicoverflow]

Needs rebase.

[wtrocki]

Rebase needed.

[alexal]

@wtrocki , @craicoverflow please see a new PR #1027. This one can be closed as I lost my old local repo.