Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename flag for get and download commands #943

Merged
merged 2 commits into from
Aug 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cmd/registry/artifact/crud/get/get.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ rhoas service-registry artifact get --group mygroup --instance-id=myregistry --a
cmd.Flags().StringVarP(&opts.artifact, "artifact-id", "a", "", "Id of the artifact")
cmd.Flags().StringVarP(&opts.group, "group", "g", util.DefaultArtifactGroup, "Group of the artifact")
cmd.Flags().StringVar(&opts.registryID, "instance-id", "", "Id of the registry to be used. By default uses currently selected registry")
cmd.Flags().StringVar(&opts.outputFile, "output-file", "", "Filename of the output file")
cmd.Flags().StringVar(&opts.outputFile, "file-location", "", "Location of the output file")
cmd.Flags().StringVar(&opts.version, "version", "", "Version of the artifact")

flagutil.EnableOutputFlagCompletion(cmd)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/registry/artifact/download/download.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ rhoas service-registry artifact download --hash=c71d239df91726fc519c6eb72d318ec6
cmd.Flags().Int64VarP(&opts.globalId, "global-id", "", unusedFlagIdValue, "Global ID of the artifact")
cmd.Flags().Int64VarP(&opts.contentId, "content-id", "", unusedFlagIdValue, "ContentId of the artifact")

cmd.Flags().StringVarP(&opts.outputFile, "output-file", "f", "", "Filename of the output file")
cmd.Flags().StringVarP(&opts.outputFile, "file-location", "", "", "Location of the output file")
cmd.Flags().StringVar(&opts.registryID, "instance-id", "", "Id of the registry to be used. By default uses currently selected registry")

flagutil.EnableOutputFlagCompletion(cmd)
Expand Down