feat(consumer-group list): add search flag #813
Conversation
| "github.com/redhat-developer/app-services-cli/pkg/localize" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
Should this be correct regexp? ( alphanumeric and hyphen).
There was a problem hiding this comment.
Asked in like that contains regexp. For me this looks reasonable, but lets see if that is aligned with backend
| ) | ||
|
|
||
| const ( | ||
| legalSearchChars = "^[a-zA-Z0-9-]+$" |
There was a problem hiding this comment.
What validation for search you have in backend @sknot-rh @MikeEdgar ?
There was a problem hiding this comment.
Which search filter does this apply to? The topic query param?
There was a problem hiding this comment.
It is for group-id-filter param.
There was a problem hiding this comment.
@rkpattnaik780 , @wtrocki - there is currently no validation for that param.
There was a problem hiding this comment.
@wtrocki @MikeEdgar @craicoverflow should we restrict special characters for this argument? Passing * gets into filesystem.
There was a problem hiding this comment.
@craicoverflow turns out validators wont prevent us from this glitch, user needs to use double quotes. Shall I get rid of validation here altogether?
There was a problem hiding this comment.
Ah I see. yes do, thanks.
rkpattnaik780
force-pushed
the
consumer_group_filter
branch
from
7323457 to
d05b88e
Compare
Add
--searchflag for consumer group list.Closes #714
Verification Steps
Type of change
Checklist