-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable self updating CLI #1509
Conversation
f594812
to
1af5383
Compare
Verified after updating golang version in local |
I think we need to test this version over the different machines/operating systems. @rkpattnaik780 do you mind creating alpha release with this version so we can test it end to end on platforms like windows, mac and linux? |
On it! |
c6169a3
to
3e5bd18
Compare
We will need to bump version in release workflow to |
Done little bit testing on the windows and mac. All seems to be working fine but additional changes are needed to inform user about update and add note that we need sudo if cli is located in folder that user cannot have write permission. |
Updated version now asks users for permission and also mention that root is required.
|
This is ready to be reviewed. |
Looking for review :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified with linux! Works great :D
Add ability for CLI to self update itself. This requires more testing with actual release builds and general improvements
This PR will only work for latest release with manual darwin binary.
We need fix upstream: rhysd/go-github-selfupdate#48
Verification
rhoas kafka list -v
Putting binary into system folder would fail and will require sudo to update