Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable command collections #1349

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Enable command collections #1349

merged 2 commits into from
Dec 13, 2021

Conversation

wtrocki
Copy link
Collaborator

@wtrocki wtrocki commented Dec 10, 2021

Enable telemetry for RHOAS

Telemetry was disabled this change removes temporary

This change requires release both upstream and downstream

Verification happy path

  1. Download official build for that PR: https://github.com/redhat-developer/app-services-cli/releases/tag/v0.36.0-dev1
  2. Execute any command (you should be asked for telemetry consent)
  3. Review usage in the woopra (ping me if you do not have access)

Disabled access

Verify if env var disables and enables telemetry:

  1. RHOAS_TELEMETRY=false rhoas status
  2. RHOAS_TELEMETRY=true
  3. RHOASCONFIG=/tmp/test.json rhoas kafka list

Verify programatic access:

  1. wget https://gist.githubusercontent.com/wtrocki/aba66607aba5dcbddf234cafcd0aa4e1/raw/249425b98cad25dfdb354ab6ef7e6a526b8af46d/rhoasStatus.js

  2. Execute "node rhoasStatus.js"

stdout:
Service Registry

ID: 912ae7a0-abea-4adf-875c-3e71b1cad21b
Name: tes3
Status: ready
Registry URL:

@wtrocki wtrocki changed the title fix: enable telemetry Enable command collections Dec 10, 2021
@craicoverflow
Copy link
Contributor

While this bit works, I have noticed that the section needs some improvements, which should be done before the official release/closing of this work.

Before

Help us to improve RHOAS cli by allowing it to collect annonymous usage data. 
Read about our privacy statement: https://developers.redhat.com/article/tool-data-collection 
You can also disable telemetry by using RHOAS_TELEMETRY=false environment variable

Suggested

Help us to improve RHOAS CLI by allowing it to collect anonymous usage data. 
Read about our privacy statement: https://developers.redhat.com/article/tool-data-collection 
You can also disable telemetry by setting the "RHOAS_TELEMETRY" environment variable to false.

I also recall in a previous meeting we were told that https://developers.redhat.com/article/tool-data-collection is not actually the privacy statement and we should not call it that. Did we get an updated link to use instead pointing to the actual statement or do we need to change the wording to say "Read our Telemetry data collection notice"?

Copy link
Contributor

@craicoverflow craicoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@wtrocki
Copy link
Collaborator Author

wtrocki commented Dec 13, 2021

Updated. WDYT?

@craicoverflow
Copy link
Contributor

Perfect.

@wtrocki wtrocki merged commit d41d05a into main Dec 13, 2021
@wtrocki wtrocki deleted the analitics branch December 13, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants