Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kafka acl): add convenience commands #1179

Merged
merged 12 commits into from
Oct 12, 2021
Merged

feat(kafka acl): add convenience commands #1179

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b68a8fc
feat(kafka acl): add convenience commands
rkpattnaik780 Oct 11, 2021
15262ad
fix: format error message
rkpattnaik780 Oct 11, 2021
902c601
fix: remove admin operation from grant-permission
rkpattnaik780 Oct 11, 2021
a801b9c
fix: address review comments
rkpattnaik780 Oct 11, 2021
d4b2545
fix: address review comments
rkpattnaik780 Oct 11, 2021
ad6b9ff
fix: fix list order
wtrocki Oct 11, 2021
f31f60f
docs: add examples for simultaneos produce, consume
rkpattnaik780 Oct 11, 2021
b6b9219
fix: typo in i18n string
rkpattnaik780 Oct 11, 2021
a2e17fa
fix: pass group prefix
Oct 11, 2021
7a66709
fix: change strings and pass pointer for aclbinding
rkpattnaik780 Oct 12, 2021
8ab4831
docs: change missing operation message
rkpattnaik780 Oct 12, 2021
96e4788
docs: format flag
rkpattnaik780 Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions docs/commands/rhoas_kafka_acl.adoc
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

72 changes: 72 additions & 0 deletions docs/commands/rhoas_kafka_acl_grant-permissions.adoc
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/commands/rhoas_kafka_acl_list.adoc
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pkg/cmd/kafka/acl/acl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package acl

import (
"github.com/redhat-developer/app-services-cli/pkg/cmd/factory"
"github.com/redhat-developer/app-services-cli/pkg/cmd/kafka/acl/grant"
"github.com/redhat-developer/app-services-cli/pkg/cmd/kafka/acl/list"
"github.com/spf13/cobra"
)
Expand All @@ -18,6 +19,7 @@ func NewAclCommand(f *factory.Factory) *cobra.Command {

cmd.AddCommand(
list.NewListACLCommand(f),
grant.NewGrantPermissionsACLCommand(f),
)

return cmd
Expand Down
Loading