Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipelines-output): add pipelinerun output tab component #7

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

karthikjeeyar
Copy link
Collaborator

@karthikjeeyar karthikjeeyar commented Jan 19, 2024

Description:

  • Added Pipelines output tab components
  • Added docs in storybook for all those components

Screenshots:

ACS_Deployment_check

ACS_ImageCheck

EC and ACS Image Scan

Test coverage:

image

@MariaLeonova
Copy link

@karthikjeeyar the EC part looks great! What happens when you expand a failed / warning task?

packages/pipelines/package.json Show resolved Hide resolved
packages/pipelines/src/components/index.ts Outdated Show resolved Hide resolved
@karthikjeeyar
Copy link
Collaborator Author

@MariaLeonova Here is the expanded view for the EC rows

image

@MariaLeonova
Copy link

That looks really good! Can I ask about the date format - what does the T00:00:00Z stand for?

@karthikjeeyar
Copy link
Collaborator Author

karthikjeeyar commented Jan 23, 2024

what does the T00:00:00Z stand for?

@MariaLeonova It is ISO string format, I have updated it to human readable format

image

@rohitkrai03 rohitkrai03 merged commit 7bbd9b4 into redhat-developer:main Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants