avoid the hosts populated by a constructed inventory to be removed #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarmu
requested review from
Tompage1994,
silvinux,
sean-m-sullivan and
djdanielsson
Tompage1994
requested changes
Jan 3, 2024
I agree... I'm thinking on how to introduce these tests... |
Tompage1994
approved these changes
Jan 3, 2024
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
…edhat-cop#747) * avoid the hosts populated by a constructed inventory to be removed * add tests for the hosts diff * remove the hosts that are not present in the CI workflow
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
…edhat-cop#747) * avoid the hosts populated by a constructed inventory to be removed * add tests for the hosts diff * remove the hosts that are not present in the CI workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
avoid the hosts populated by a constructed inventory to be removed, the same way it is controlled for the smart inventories and the inventories that are defining inventory sources.
How should this be tested?
Automatic tests are not controlling this kind of scenarios.
Is there a relevant Issue open for this?
resolves #743
Other Relevant info, PRs, etc
N/A