-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
constructed inventory source skip #720
constructed inventory source skip #720
Conversation
279c9fe
to
8340be5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once the tests start working
a7c69f0
to
8929559
Compare
8929559
to
b0099ac
Compare
Having you reaprove as more changes including some changing our testing, the problem being constructed inventory, and adding new versions of awx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
The role 'inventory_sources' will now skip when the source parameter is
constructed
. These sources are auto created and not meant to be edited. However they can still be synced with the inventory_source_update.How should this be tested?
Automated tests
Is there a relevant Issue open for this?
#601