Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#630 - Fix default for enforce_defaults #631

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

Tompage1994
Copy link
Collaborator

What does this PR do?

Fixes the default enforce_default value to be false rather than the truthy value of 'false'

How should this be tested?

We might want to add some kind of CI around this. Should we raise an issue to do this?

Is there a relevant Issue open for this?

resolves #630

Other Relevant info, PRs, etc

N/A

Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson enabled auto-merge (squash) June 22, 2023 14:07
@djdanielsson djdanielsson merged commit ab7b572 into redhat-cop:devel Jun 22, 2023
djdanielsson pushed a commit that referenced this pull request Jun 23, 2023
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong default for controller_configuration_enforce_defaults variables
2 participants