Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dispatch to use general vars instead of specific hostvars #547

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

Klaas-
Copy link
Contributor

@Klaas- Klaas- commented Mar 20, 2023

What does this PR do?

Change the when clause for variable lookup of the dispatch role to vars instead of hostvars

How should this be tested?

This should not modify behavior except for also including vars that are for example set on the play level.

Is there a relevant Issue open for this?

No

Copy link
Collaborator

@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, I knew there were some issues with variable loading when not set against a host but I couldn't find a better way.

I never knew that there was a special variable called vars. Every day's a school day! Thanks

@Tompage1994 Tompage1994 enabled auto-merge (squash) March 20, 2023 16:39
@Tompage1994 Tompage1994 merged commit 3839b01 into redhat-cop:devel Mar 20, 2023
@Klaas- Klaas- deleted the Klaas-fix_dispatch branch March 21, 2023 06:26
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
…-cop#547)

* Fix dispatch to use general vars instead of specific hostvars

* Add changelog

---------

Co-authored-by: Tom Page <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants