Add back in broken linting rule #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it looks like it is still erroring |
|
Correct, there still seems to be issues with ansible-lint so lets wait until the next version has been released. There are numerous related issues for this over there. |
|
looks like this is now fixed in ansible-lint but hasn't been released yet. Reopening this and marking as draft until 6.14.1 released |
|
I am trying this again, the lint was updated, YOur ball @Tompage1994 as you understand it |
|
Pre-commit working now so this is good to go |
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
* Add back in broken linting rile * Add in undefined variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously broken linting rule has been fixed in current version of ansible-lint. (Although we merged a pre-release version which I don't like) This shouldn't now fail as the error was a false positive which we had set to warn instead of fail.
How should this be tested?
CI will pass
Is there a relevant Issue open for this?
Other Relevant info, PRs, etc
This issue was fixed: ansible/ansible-lint#3048