Add argument specs for roles, remove master template role and update readmes #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realised I missed the filetree and dispatch stuff. Was meant to come back to it. I'll do those ones in a separate PR tomorrow |
Tompage1994
force-pushed
the
arg_specs
branch
4 times, most recently
from
9101a47 to
4e56188
Compare
sean-m-sullivan
approved these changes
Feb 23, 2023
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
…readmes (redhat-cop#511) * Add argument specs for roles, remove master template role and update readmes * Fix arg_spec error * Fix arg specs * Fix settings argspec * remove default:None from argspec * Fix CI objects failing arg validation * fix inventories argspec * Add unused options * Add unused options * fix schedule argspec * Don't include extra illegal options in ad_hoc_cancel * Remove incorrect argspec * Remove options from each role's argspec so extra unused values can be provided * Fix filtering of vars --------- Co-authored-by: Sean Sullivan <[email protected]>
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
…readmes (redhat-cop#511) * Add argument specs for roles, remove master template role and update readmes * Fix arg_spec error * Fix arg specs * Fix settings argspec * remove default:None from argspec * Fix CI objects failing arg validation * fix inventories argspec * Add unused options * Add unused options * fix schedule argspec * Don't include extra illegal options in ad_hoc_cancel * Remove incorrect argspec * Remove options from each role's argspec so extra unused values can be provided * Fix filtering of vars --------- Co-authored-by: Sean Sullivan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There's a lot to take in here and it took AGES to put together but I think its all correct. Any typos or minor mistakes can be cleaned up in future PRs
How should this be tested?
Reading it... (sorry)
Is there a relevant Issue open for this?
resolves #509
Other Relevant info, PRs, etc
We will need to do the same on the other collections too 😢