Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add no_log everywhere controller_api_plugin is used #478

Merged
merged 4 commits into from
Jan 26, 2023

Conversation

ivarmu
Copy link
Contributor

@ivarmu ivarmu commented Jan 26, 2023

What does this PR do?

Add no_log everywhere controller_api_plugin is used to avoid to expose sensitive information in case of crashes.

How should this be tested?

Tested manually.

Is there a relevant Issue open for this?

resolves #446

Other Relevant info, PRs, etc

N/A

Copy link
Contributor

@silvinux silvinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!. This change will avoid that the password is not stored in clear in a stdout.

@silvinux silvinux enabled auto-merge January 26, 2023 09:55
@silvinux silvinux disabled auto-merge January 26, 2023 10:10
@silvinux silvinux enabled auto-merge January 26, 2023 10:18
Copy link
Collaborator

@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but please add a changelog fragment

@ivarmu ivarmu requested a review from Tompage1994 January 26, 2023 10:46
Copy link
Collaborator

@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@silvinux silvinux merged commit 1b5c4f3 into redhat-cop:devel Jan 26, 2023
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
add no_log everywhere controller_api_plugin is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filetree_read and object_diff roles output is exposing credentials in clear text
3 participants