Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to labels option in readmes #472

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

Tompage1994
Copy link
Collaborator

What does this PR do?

Adds note to labels option of workflow and JT roles to point out that the label must first be created as per the discussion in #344

How should this be tested?

resolves #344

Other Relevant info, PRs, etc

N/A

@Tompage1994
Copy link
Collaborator Author

Tompage1994 commented Jan 18, 2023

CI doesn't like the link I've used of /roles/labels which points to the correct directory. It should be fine becasue it shuld take to the relative page in the repo. i've checked here and it seems to be fine so I've just added a disable next line marker for the links

@Tompage1994
Copy link
Collaborator Author

After playing around it seems the only way to get a ljnk to work in both GitHub and PAH is to use the direct GitHub link rather than a relative link which would have been so much nicer, but the paths just don't match up

Copy link
Collaborator

@branic branic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@branic branic merged commit 5eea7a0 into redhat-cop:devel Jan 18, 2023
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job Template Labels not created if they don't exist
2 participants