Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added roles to object_diff #454

Conversation

ivarmu
Copy link
Contributor

@ivarmu ivarmu commented Dec 26, 2022

What does this PR do?

Adds the object type roles to the object_diff stuff. This way, the 'desired state' idea can be implemented for roles.

How should this be tested?

Tested manually

Is there a relevant Issue open for this?

N/A

Other Relevant info, PRs, etc

/N/A

@ivarmu ivarmu force-pushed the new_objects_in_object_diff branch from 9dd3ca3 to 546aa02 Compare January 4, 2023 07:57
@ivarmu ivarmu requested a review from djdanielsson January 4, 2023 08:09
Copy link
Collaborator

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Needed to test thinking we might need to add tests for this in terms of the controller api diffs, but they passed for existing tests.

@sean-m-sullivan sean-m-sullivan merged commit 500d8e8 into redhat-cop:devel Jan 4, 2023
@ivarmu ivarmu deleted the new_objects_in_object_diff branch January 26, 2023 07:49
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants