[#407] change default behavior of job_slice_count in job_launch #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarmu
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
LGTM.
Let's @djdanielsson and @sean-m-sullivan to review and approve.
adonisgarciac
changed the title
Tompage1994
approved these changes
Nov 24, 2022
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change default behavior of job_slice_count.
job_slice_count is not set by default because is only allowed when ask_job_slice_count_on_launch is true but by default it is false.
I think it is better to set job_slice_count without default 1 and give the responsibility to user who has to know when set it up due to ask_job_slice_count_on_launch is true in the JT. Moreover, JT can have a default value which is 1 if user does not change it, so I think even although user will not send job_slice_count with ask_job_slice_count_on_launch=true, it will work.
Also it will work fine in AAP 2.2 and Tower.
Is there a relevant Issue open for this?
#407