Changed path directory user filetree-read and change var drop_user_ex… #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ternal_account default value
|
LGTM! However, if you want, you can use this PR to fix the name of task misnamed: |
adonisgarciac
approved these changes
Oct 10, 2022
silvinux
requested review from
adonisgarciac and
ivarmu
and removed request for
adonisgarciac
adonisgarciac
approved these changes
Oct 10, 2022
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
Changed path directory user filetree-read and change var drop_user_ex…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1.- Variable value drop_user_external_accounts: true has been changed to drop_user_external_accounts: false so it makes sense as it is executed.
2.- Variable value filetree_controller_user_accounts: "{{ dir_orgs_vars }}/{{ orgs }}/env/{{ env }}/controller_users.d/" has been changed due it makes more sense to have different user passwords depend on the environment is pointing to.
3.- Moved users.d examples from orgs_vars/OrgExample/env/common/controller_users.d/ orgs_vars/OrgExample/env/dev/controller_users.d.
4.- Changed organization name from OrgExample to ExampleOrg. Files point to ExampleOrg.
How should this be tested?
Tested manually with playbook.