Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object diff variable verifyssl and some fixes #374

Merged

Conversation

adonisgarciac
Copy link
Contributor

What does this PR do?

1.- Add verify_ssl as a variable in object_diff role
2.- Remove auth info in the filetree_read role because this role itself will not connect to controller/tower
3.- Add auth example variables in playbooks which use filetree_read and dispatch roles.
4.- Fixes in some templates of filetree_create role

How should this be tested?

Launch test playbooks for filetree_create, filetree_read and object_diff roles.

Is there a relevant Issue open for this?

N/A

Other Relevant info, PRs, etc

Copy link
Contributor

@ivarmu ivarmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tompage1994
Copy link
Collaborator

Looks like there are some conflicts that need to be fixed.

Copy link
Contributor

@silvinux silvinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit 8bd744c into redhat-cop:devel Oct 6, 2022
@adonisgarciac adonisgarciac deleted the object_diff_variable_verifyssl branch October 10, 2022 13:48
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
…ariable_verifyssl

Object diff variable verifyssl and some fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants