Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align linting configurations with other repos #371

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

branic
Copy link
Collaborator

@branic branic commented Sep 30, 2022

What does this PR do?

This is a small linting update to align the controller_configuration linting with the other redhat_cop AAP related repos and fix any new linting errors.

How should this be tested?

Automated tests are preferred, but not always doable - especially for infrastructure. Include commands to run your new feature, and also post-run commands to validate that it worked. (please use code blocks to format code samples)

Is there a relevant Issue open for this?

Provide a link to any open issues that describe the problem you are solving.
resolves #[number]

Other Relevant info, PRs, etc

Please provide link to other PRs that may be related (blocking, resolves, etc. etc.)

Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit 839528b into redhat-cop:devel Oct 1, 2022
@branic branic deleted the consistent_linting branch November 12, 2022 00:03
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
Align linting configurations with other repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants