Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve oauthtoken #365

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

adonisgarciac
Copy link
Contributor

@adonisgarciac adonisgarciac commented Sep 26, 2022

What does this PR do?

This PR try to improve the managment of oauthtoken for filetree_create, filetree_read and object_diff roles and some other fixes which they were seen during tests:

  1. oauthtoken var is renamed because follow naming of the rest of roles: oauthtoken -> controller_oauthtoken
  2. Control if controller_oauthtoken is given, the roles will not create the oauth token
  3. If oauth token is created, it will be deleted at the end.
  4. Remove generate token in filetree_read because this role only is to read variable definitions.
  5. Add check what collection ansible.controller or ansible.awx is installed for object_diff role
  6. fix controller_object_diff.py: it was I was handling credential_type as it would have organization.

How should this be tested?

Launch test playbooks for filetree_create, filetree_read and object_diff roles.

Is there a relevant Issue open for this?

N/A

Other Relevant info, PRs, etc

I think that, after this PR will be merged, I should generate a new release version because we have a lot of new features and fixes and we already have customers testing CasC using these roles.

Copy link
Contributor

@silvinux silvinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome job!.

Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit c1c6c07 into redhat-cop:devel Sep 27, 2022
@adonisgarciac adonisgarciac deleted the improve_oauthtoken branch October 10, 2022 13:48
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants