Bug/fix credentials role ignoring update secrets (#651)

* should not force 'default' to true when update_secrets is fales * should not force 'default' to true when update_secrets is fales
redhat-cop · Jul 20, 2023 · 9f25df4 · 9f25df4
1 parent 80fb202
commit 9f25df4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/changelogs/fragments/credentials_role_bugfix.yml b/changelogs/fragments/credentials_role_bugfix.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - fix 'credentials' role ignoring 'update_secrets: false' and forcing to default 'true'
diff --git a/roles/credentials/tasks/main.yml b/roles/credentials/tasks/main.yml
@@ -10,7 +10,7 @@
     inputs:                         "{{ __controller_credentials_item.inputs | default(( {} if controller_configuration_credentials_enforce_defaults else omit), true) }}"
     user:                           "{{ __controller_credentials_item.user.username | default(__controller_credentials_item.user | default(( '' if controller_configuration_credentials_enforce_defaults else omit), true)) }}"
     team:                           "{{ __controller_credentials_item.team.name | default(__controller_credentials_item.team | default(( '' if controller_configuration_credentials_enforce_defaults else omit), true)) }}"
-    update_secrets:                 "{{ __controller_credentials_item.update_secrets | default(( true if controller_configuration_credentials_enforce_defaults else omit), true) }}"
+    update_secrets:                 "{{ __controller_credentials_item.update_secrets | default( true if controller_configuration_credentials_enforce_defaults else omit) }}"
     state:                          "{{ __controller_credentials_item.state | default(controller_state | default('present')) }}"
 
     # Role specific options
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- fix 'credentials' role ignoring 'update_secrets: false' and forcing to default 'true'