Skip to content

Commit

Permalink
Added docs and optomize for attaching load balancer for azure
Browse files Browse the repository at this point in the history
  • Loading branch information
sabre1041 committed Jan 18, 2022
1 parent 07f9bf2 commit 2e4710f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 1 addition & 2 deletions controllers/egressipam/azure/azure.go
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,6 @@ func (i *AzureInfra) removeUnNeededAzureAssignedIPs(rc *reconcilecontext.Reconci

func (i *AzureInfra) addNeededAzureAssignedIPs(rc *reconcilecontext.ReconcileContext) error {
results := make(chan error)
attachInternalLoadBalancerPool := shouldAttachInternalLoadBalancerPool(rc.EgressIPAM)
defer close(results)
for node, ips := range rc.FinallyAssignedIPsByNode {
nodec := node
Expand Down Expand Up @@ -457,7 +456,7 @@ func (i *AzureInfra) addNeededAzureAssignedIPs(rc *reconcilecontext.ReconcileCon
}
}
}
if attachInternalLoadBalancerPool {
if shouldAttachInternalLoadBalancerPool(rc.EgressIPAM) {
loadBalancerBackendAddressPools = (*networkInterface.IPConfigurations)[0].LoadBalancerBackendAddressPools
}
ipConfigurations := *networkInterface.IPConfigurations
Expand Down
2 changes: 2 additions & 0 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ When a namespace with the opt-in annotation is created, the following happens:
4. the relative Azure machine is assigned the additional IP on the primary NIC (support for secondary interfaces in not available).
5. the relative `hostsubnet` is updated to reflect the assigned IP, the `egressIP` field is updated.

By default, the Egress IP address is added to the members of the backend pool of the load balancer. The determination of whether to attach this assignment is configured through the `egressip-ipam-operator.redhat-cop.io/azure-load-balancer-attach=<true|false>` annotation.

## Support for vSphere

Egress-ipam-operator treats vSphere as a bare metal installation, so it will work with a network setup in which secondary IPs can be added to the VMs with no interaction with the vSphere API.
Expand Down

0 comments on commit 2e4710f

Please sign in to comment.