Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dont allow consecutive clicks #1435

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: Dont allow consecutive clicks #1435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion catalog/ui/src/app/Catalog/CatalogItemForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ const CatalogItemFormData: React.FC<{ catalogItemName: string; catalogNamespaceN
const navigate = useNavigate();
const debouncedApiFetch = useDebounce(apiFetch, 1000);
const [autoStopDestroyModal, openAutoStopDestroyModal] = useState<TDatesTypes>(null);
const [isLoading, setIsLoading] = useState(false);
const { isAdmin, groups, roles, serviceNamespaces, userNamespace } = useSession().getSession();
const { data: catalogItem } = useSWRImmutable<CatalogItem>(
apiPaths.CATALOG_ITEM({ namespace: catalogNamespaceName, name: catalogItemName }),
Expand Down Expand Up @@ -106,7 +107,7 @@ const CatalogItemFormData: React.FC<{ catalogItemName: string; catalogNamespaceN
const purposeObj = PurposeOpts.find(
(p) => activityObj && formState.purpose && activityObj.id === p.activityId && formState.purpose.startsWith(p.name)
);
const submitRequestEnabled = checkEnableSubmit(formState);
const submitRequestEnabled = checkEnableSubmit(formState) && !isLoading;

useEffect(() => {
if (!formState.conditionChecks.completed) {
Expand All @@ -124,6 +125,10 @@ const CatalogItemFormData: React.FC<{ catalogItemName: string; catalogNamespaceN
if (!submitRequestEnabled) {
throw new Error('submitRequest called when submission should be disabled!');
}
if (isLoading) {
return null;
}
setIsLoading(true);
const parameterValues: CreateServiceRequestParameterValues = {};
for (const parameterState of Object.values(formState.parameters)) {
// Add parameters for request that have values and are not disabled or hidden
Expand Down Expand Up @@ -200,6 +205,7 @@ const CatalogItemFormData: React.FC<{ catalogItemName: string; catalogNamespaceN

navigate(`/services/${resourceClaim.metadata.namespace}/${resourceClaim.metadata.name}`);
}
setIsLoading(false);
}

if (catalogItem.spec.externalUrl) {
Expand Down