Perf improvement: process '-has' flag at the end #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--has
flag is costly because it forces variables to be merged. When looping over a lot of catalog items, it can slow down the command a lot.Move its processing at the last position when filtering catalog items, so it's executed less often when used in combination of other flags.
This will help in agnosticv-operator.
Here is the improvement from 5s to 0.5s of execution time for a command: