Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom related file through config file #17

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

fridim
Copy link
Contributor

@fridim fridim commented Jan 10, 2023

Introduce new config file /.agnosticv.yaml to allow adding related files:

---
related_files:
  - service-ready-message-template.html.j2
  - service-ready-message-template.html
  • Update README
  • Fix parseFlags() in order to set rootFlag too
  • Fix initLoggers() to have no dependency and be executed as first
  • Move logDebug definition into parseFlags() as it depends on a flag --debug.
  • Update isPathCatalogItem() to ignore related files
  • Implement a simple config reader in config.go
  • workDir doesn't have to be a global var

@fridim fridim requested a review from aleixhub January 10, 2023 14:26
Copy link

@aleixhub aleixhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fridim fridim marked this pull request as ready for review January 11, 2023 10:38
Introduce new config file `/.agnosticv.yaml` to allow adding related files:

```yaml
---
related_files:
  - service-ready-message-template.html.j2
  - service-ready-message-template.html

```

- Update README
- Fix parseFlags() in order to set rootFlag too
- Fix initLoggers() to have no dependency and be executed as first
- Move logDebug definition into parseFlags() as it depends on a flag --debug.
- Update isPathCatalogItem() to ignore related files
- Implement a simple config reader in `config.go`
- workDir doesn't have to be a global var
- Add a test to ensure .agnosticv.conf is working and related_file.yaml
is not considered as a catalog item
@fridim fridim merged commit de5c524 into master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants