new feature: meta files #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only support __meta__ - meta file has the content of __meta__ var directly, no need to keep the key
- included file can have a meta file - meta file can be included directly
Support both approach - If __meta__ is found, use it Ensure there is no other variables defined in the meta file. Everything should be under __meta__ - If __meta__ is not found, consider the content as the content of __meta__ and inject everything back to __meta__
fridim
added a commit
that referenced
this pull request
Oct 11, 2022
This change, if applied, adds Git information into the merged vars. The
path is `__meta__.merge_info.git` and looks like:
```
__meta__:
merge_info:
git:
author: Guillaume Coré <[email protected]>
hash: 5cc118e
message: 'new feature: meta files (#15)'
when: "2022-09-05T09:55:16Z"
```
see GPTEINFRA-4542
fridim
added a commit
that referenced
this pull request
Oct 11, 2022
This change, if applied, adds Git information into the merged vars. The
path is `__meta__.merge_info.git` and looks like:
```
__meta__:
merge_info:
git:
author: Guillaume Coré <[email protected]>
hash: 5cc118e
message: 'new feature: meta files (#15)'
when: "2022-09-05T09:55:16Z"
```
see GPTEINFRA-4542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change, if applied, adds a new feature to agnosticv CLI to allow meta files.
Meta files would allow catalog maintainers to separate the usual variables for the deployer (agnosticd) and the meta variables for babaylon (
__meta__).See readme.adoc diff in the change.
GPTEINFRA-4213
Tested using
tools/test_new_version.shagainst v0.4.1 on our production agnosticv repo