Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.13] Bug OCPBUGS-26508: PTP metrics still includes metrics for old config after deleting a ptpconfig #284

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

aneeshkp
Copy link
Member

@aneeshkp aneeshkp commented Jan 9, 2024

fix metrics clean up on delete of ptp config

@openshift-ci-robot
Copy link

@aneeshkp: This pull request references Jira Issue OCPBUGS-26508, which is invalid:

  • expected Jira Issue OCPBUGS-26508 to depend on a bug targeting a version in 4.14.0, 4.14.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

fix metrics clean up on delete of ptp config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved label Jan 9, 2024
@jzding jzding changed the title OCPBUGS-26508: PTP metrics still includes metrics for old config after deleting a ptpconfig [release-4.13] Bug OCPBUGS-26508: PTP metrics still includes metrics for old config after deleting a ptpconfig Jan 9, 2024
@aneeshkp
Copy link
Member Author

/jjira-refresh

@jzding
Copy link
Member

jzding commented Jan 17, 2024

/jira refresh

@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-26508, which is invalid:

  • expected dependent Jira Issue OCPBUGS-26238 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jzding
Copy link
Member

jzding commented Jan 31, 2024

/jira refresh

@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-26508, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-26238 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-26238 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hhassid
Copy link

hhassid commented Jan 31, 2024

/label cherry-pick-approved

Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

@hhassid: The label(s) cherry-pick-approved cannot be applied, because the repository doesn't have them.

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jzding jzding merged commit 379c213 into redhat-cne:release-4.13 Feb 1, 2024
4 of 5 checks passed
@openshift-ci-robot
Copy link

@aneeshkp: Jira Issue OCPBUGS-26508: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26508 has been moved to the MODIFIED state.

In response to this:

fix metrics clean up on delete of ptp config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cloud-event-proxy-container-v4.13.0-202402011609.p0.g379c213.assembly.stream for distgit cloud-event-proxy.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants