Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-25547: PTP metrics still includes metrics for old config after deleting a ptpconfig #281

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

aneeshkp
Copy link
Member

@aneeshkp aneeshkp commented Jan 3, 2024

fix metrics clean up for GM

@openshift-ci-robot
Copy link

@aneeshkp: This pull request references Jira Issue OCPBUGS-25547, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

fix metrics clean up for GM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from atyronesmith and jzding January 3, 2024 15:16
@openshift-ci openshift-ci bot added the approved label Jan 3, 2024
@aneeshkp
Copy link
Member Author

aneeshkp commented Jan 3, 2024

/jira-refresh

@aneeshkp
Copy link
Member Author

aneeshkp commented Jan 3, 2024

/jira refresh

@openshift-ci-robot
Copy link

@aneeshkp: This pull request references Jira Issue OCPBUGS-25547, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

}

log.Infof("depends on end %s", p.PrintDependsOn())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove temporary logs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@aneeshkp aneeshkp force-pushed the clear-metrics branch 2 times, most recently from b20a6e8 to b6ebd0c Compare January 3, 2024 19:23
@jzding
Copy link
Member

jzding commented Jan 3, 2024

/test e2e-aws

Copy link
Contributor

openshift-ci bot commented Jan 3, 2024

@aneeshkp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 2f3c966 link false /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jzding
Copy link
Member

jzding commented Jan 3, 2024

/test e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit e2f09b7 into redhat-cne:main Jan 3, 2024
5 of 6 checks passed
@openshift-ci-robot
Copy link

@aneeshkp: Jira Issue OCPBUGS-25547: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25547 has been moved to the MODIFIED state.

In response to this:

fix metrics clean up for GM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cloud-event-proxy-container-v4.16.0-202401040010.p0.ge2f09b7.assembly.stream for distgit cloud-event-proxy.
All builds following this will include this PR.

@aneeshkp
Copy link
Member Author

aneeshkp commented Jan 4, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@aneeshkp: new pull request created: #282

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants