Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New certificate schema, mandatory type, chart sha and timestamp #75

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

mmulholla
Copy link
Collaborator

This PR covers several things

  1. New schema implemented. See "Certificate" struct in chartverifier/Certificate.go
  2. Added ability to mark checks as Mandatory, Optional or Experimental. All current checks are mandatory
  3. Generating a sha256 value for the chart. Basically sort all files into alphabetic order and then create sha from their content. Test case repeatedly creates sha calues for test charts making sure they are always the same.
  4. Report is output to console and no longer a file. Running locallly use "command 2> report.yaml", running docker image just "command > report.yaml"
  5. Default output is now yaml.
  6. Some tests had to be updated for the new changes and schema

@mmulholla mmulholla requested review from isutton, baijum and pedjak April 15, 2021 21:03
pkg/chartverifier/certificate.go Show resolved Hide resolved
pkg/chartverifier/certificate.go Show resolved Hide resolved
pkg/chartverifier/certificate.go Show resolved Hide resolved
pkg/chartverifier/certificatebuilder.go Outdated Show resolved Hide resolved
pkg/chartverifier/checks/registry.go Outdated Show resolved Hide resolved
pkg/chartverifier/helmcertifier.go Show resolved Hide resolved
pkg/chartverifier/certificate.go Show resolved Hide resolved
pkg/chartverifier/certificate.go Show resolved Hide resolved
pkg/chartverifier/certificate.go Show resolved Hide resolved
pkg/chartverifier/certificate.go Show resolved Hide resolved
pkg/chartverifier/certificatebuilder.go Outdated Show resolved Hide resolved
pkg/chartverifier/certificate.go Outdated Show resolved Hide resolved
@mmulholla
Copy link
Collaborator Author

@isutton @pedjak Some of the comments relate to use of certificate instead of report. I used certificate because it is consistent with the rest of the code. The schema is in Cerificate.go, it is created from certificatebuilder.go, the check process is created by certifierbuilder.go and run by certifier.go. If we use Report for the schema we should change all of those, the object and funcs too. Thoughts?

@pedjak
Copy link
Contributor

pedjak commented Apr 19, 2021

If we use Report for the schema we should change all of those, the object and funcs too. Thoughts?

Yes, change everything what is needed.

@mmulholla mmulholla force-pushed the NewSchemaPlus branch 3 times, most recently from 3e6da33 to f1ec2e7 Compare April 19, 2021 17:00
@mmulholla
Copy link
Collaborator Author

@pedjak @isutton : have addressed the comments which are not connected to using report instead of certificate - for those comments and the entire rename effort I opened a new issue #78

@mmulholla mmulholla dismissed isutton’s stale review April 20, 2021 18:17

all chnages have been merged or deferred to #78

@mmulholla mmulholla merged commit dd16f0f into redhat-certification:main Apr 20, 2021
@mmulholla mmulholla linked an issue Apr 20, 2021 that may be closed by this pull request
mmulholla referenced this pull request in mmulholla/chart-verifier Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create report schema
3 participants