Check images for an empty image string #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OchiengEd
force-pushed
the
empty-image
branch
2 times, most recently
from
6f07ef1 to
00c6a15
Compare
komish
reviewed
Jul 27, 2023
komish
reviewed
Jul 27, 2023
OchiengEd
force-pushed
the
empty-image
branch
3 times, most recently
from
4e4e8d8 to
8dcdf16
Compare
Update the getImagesFromContent function to return all images, including empty ones. In addition, when evaluating images received in certifyImages() function, skip evaluating registries for any empty images Signed-off-by: Edmund Ochieng <[email protected]>
Signed-off-by: Edmund Ochieng <[email protected]>
Signed-off-by: Edmund Ochieng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
getImagesFromContentfunction to return all images, including empty ones.In addition, when evaluating images received in certifyImages() function, skip evaluating registries for any empty images
These changes also have a performance improvement. Unlike the previous implementation of the function that evaluated each line of the generated helm templates for images.
Closes #347