Change users models #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django default user already has email, first_name, last_name. I removed those 3 fields from our User and created a static method that will create our user with all required fields. Also included some tests - from now on we must write tests for each PR
AvivLiberman
requested review from
aradz1997,
Asafh7,
mgold1234,
nunnatsa,
avraham1992,
orzionpour and
natifridman
I saw that django generates in the DB _id for each field that is foreign key. Better to remove it now.
orzionpour
reviewed
Nov 22, 2021
|
As for the test and functions: |
|
I don't want that PR to be big. Any other ideas you have to add more functionality open an issue about it |
Asafh7
previously approved these changes
Nov 22, 2021
- Change tests to pytest - Removed dummy test - Create factory for tests
On admin panel first_name no longer exists so it failed. Changed it to take the username from auth user.
aradz1997
approved these changes
Nov 23, 2021
orzionpour
previously approved these changes
Nov 23, 2021
aradz1997
requested changes
Nov 23, 2021
Asafh7
previously approved these changes
Nov 23, 2021
orzionpour
previously approved these changes
Nov 23, 2021
aradz1997
approved these changes
Nov 23, 2021
|
Why |
- removed conftest.py - added tests in classes - changed models realated_name
AvivLiberman
dismissed stale reviews from aradz1997, orzionpour, and Asafh7
via
2556f41
you are right - I removed it |
Asafh7
previously approved these changes
Nov 25, 2021
orzionpour
previously approved these changes
Nov 25, 2021
orzionpour
previously approved these changes
Nov 26, 2021
removed email from test_create_user_without_email added long name to test_create_user_with_long_name
orzionpour
approved these changes
Nov 26, 2021
Asafh7
approved these changes
Nov 26, 2021
natifridman
approved these changes
Nov 26, 2021
orzionpour
added a commit
to orzionpour/falcon
that referenced
this pull request
Nov 26, 2021
- Fix merge between redhat-beyond#66 and redhat-beyond#72
orzionpour
added a commit
to orzionpour/falcon
that referenced
this pull request
Nov 26, 2021
- Fix merge between redhat-beyond#66 and redhat-beyond#72
mgold1234
pushed a commit
that referenced
this pull request
Nov 29, 2021
* Fix merge between PRs - Fix merge between #66 and #72 * Create conftest.py - Create conftest.py for reusable fixtures * Add change_assignee function - Add change_assignee function to Task model. - Add tests for change_assignee * Refactor conftest.py - Removed use of Random to prevent unexpected behavior in tests. - Changed to named parameters in user creations. * Handle special cases - Add new tests to validate the correctness of the function in special cases. * Fix flake8 error * Update change_assignee - Add new user case handling: new_assignee is a user but not part of the system (not in DB) - Add corresponding test * Refactor conftest.py * Refactor conftest.py * Refactor test_change_assignee.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
Django default user already has email, first_name, last_name.
I removed those 3 fields from our User and .
Changes you made
from now on we must write tests for each PR