Get subscription channel from package manifest if it is not present #2551
Conversation
|
from change #2551: |
edcdavid
force-pushed
the
get-default-channel
branch
from
9060ec2 to
8c667d5
Compare
|
from change #2551: |
There was a problem hiding this comment.
Looks good. I believe you can also spoof the dynamicClient to add unit testing if you wanted.
eco-goinfra has some logic added for testing DynamicClient objects here: https://github.com/openshift-kni/eco-goinfra/blob/8cdb9cd573a3bf5ec2903467abc3619e56575ccd/pkg/clients/clients.go#L327
|
from change #2551: |
|
/dci-rerun |
|
from change #2551: |
edcdavid
force-pushed
the
get-default-channel
branch
from
3df1805 to
02a8af9
Compare
|
from change #2551: |
|
/dci-rerun |
|
from change #2551: |
|
/dci-rerun |
|
from change #2551: |
|
As you may see in the change, the failure reason is that the certsuite container image is not correctly built, this probably needs to be reviewed on your side to make it work. |
@ramperher thanks for the comment. I'll fix it |
edcdavid
force-pushed
the
get-default-channel
branch
from
02a8af9 to
0aae8de
Compare
|
from change #2551: |
edcdavid
force-pushed
the
get-default-channel
branch
from
0aae8de to
ab44850
Compare
|
from change #2551: |
edcdavid
merged commit 612305a
into
redhat-best-practices-for-k8s:main
|
from change #2551: |
Depends-On: redhat-best-practices-for-k8s/oct#221
When creating a subscription using a default channel, the "spec->channel" parameter is not required. However we need this parameter to perform the certification test for operators.
When the spec->channel parameter is empty, get the package manifest corresponding to the subscription, retrieve the default channel and use it for the operator certification test
Update: the channel is not an attribute of the operator but of the catalog, so I believe we can check certification without it. If an user creates a custom catalog with a channel name not matching the one in the catalog this test would fail otherwise when it should not.
Leaving the packageManifest discovery code in since it could be needed in the future