networking: Add MTU value test for SRIOV NAD's #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
force-pushed
the
operator_sriov_pods_mtu
branch
from
2dcd767 to
baf7653
Compare
|
from change #2514: |
bnshr
reviewed
Oct 14, 2024
greyerof
approved these changes
Oct 15, 2024
sebrandon1
force-pushed
the
operator_sriov_pods_mtu
branch
from
baf7653 to
37ee7d4
Compare
|
from change #2514:
|
|
from change #2514: |
|
/dci-rerun |
bnshr
approved these changes
Oct 16, 2024
sebrandon1
force-pushed
the
operator_sriov_pods_mtu
branch
from
37ee7d4 to
af67783
Compare
|
from change #2514: |
|
Should there be a QE test for this which can be skipped based on the unavailability of the hardware? |
|
@bnshr Yes, that would be the goal for this test I'd say. We'll need some sort of hardware environment to test it. |
sebrandon1
merged commit a37ed97
into
redhat-best-practices-for-k8s:main
34 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test that checks that Network Attachment Definitions are specifying their MTU values explicitly.
EDIT: I was trying to follow the quick start guide here for the SRIOV network operator but I don't have access to the necessary hardware.
We'll have to maybe figure out how to test this via QE on supported hardware in the future.