-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Setter and Getter functions to results spreadsheet google creds #2443
Add Setter and Getter functions to results spreadsheet google creds #2443
Conversation
from change #2443: |
cmd/certsuite/upload/results_spreadsheet/results_spreadsheet.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a way to solve it, but it doesn't look like a good approach to me, as the setters/getters use an internal global/package var. I would probably change the CreateSheetsAndDriveServices
to add an extra string argument for that credentails path.
I agree - That's a better idea. I'll do the change, thanks! |
from change #2443: |
e939106
into
redhat-best-practices-for-k8s:main
from change #2443: |
This PR adds
credentials
as an argument ofCreateSheetsAndDriveServices
func in order to allow the use of it independently from usingupload results-spreadsheet
sub-command.In current state, the credentials are sent using a flag to the mentioned sub command, which limits functions using this variable to run using the sub-command only.
In the
operator-results-spreadsheet
repo, we would like to allow the use ofCreateSheetsAndDriveServices
func (which uses thecredentials
variable) in order to add more columns to an existing sheet, and for that we need the credentials to be set manually.