-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHTAPINST-133: Local and Embedded ChartFS #359
Conversation
@otaviof: This pull request references RHTAPINST-133 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold |
529ca3b
to
50d1638
Compare
/hold cancel I forgot to remove the |
@otaviof: This pull request references RHTAPINST-133 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
1 similar comment
/retest |
Supports local and embedded files via `ChartFS`, the component looks for the data in the local filesystem first, and if not found, it looks for the data in the embedded filesystem. The flag `--embedded` is removed.
50d1638
to
dc56e8a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: otaviof, Roming22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
@otaviof: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.16-8kgsz Test results analysis<not enabled> |
One run passed: https://console.redhat.com/application-pipeline/workspaces/rhtap-shared-team/applications/rhtap-cli/pipelineruns/e2e-4.17-b7c77
I'll keep an eye for this failure, but wouldn't hold this PR because of it. Feel free to merge from my (e2e-tests) POV |
Supports local and embedded files via
ChartFS
, the component looks for the data in the local filesystem first, and if not found, it looks for the data in the embedded filesystem.Removing the flag
--embedded
, given both local and embedded FS are working in combination.