Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHTAPINST-133: Local and Embedded ChartFS #359

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

otaviof
Copy link
Collaborator

@otaviof otaviof commented Dec 17, 2024

Supports local and embedded files via ChartFS, the component looks for the data in the local filesystem first, and if not found, it looks for the data in the embedded filesystem.

Removing the flag --embedded, given both local and embedded FS are working in combination.

@otaviof otaviof added the enhancement New feature or request label Dec 17, 2024
@otaviof otaviof requested a review from Roming22 December 17, 2024 10:13
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 17, 2024

@otaviof: This pull request references RHTAPINST-133 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Supports local and embedded files via ChartFS, the component looks for the data in the local filesystem first, and if not found, it looks for the data in the embedded filesystem.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@otaviof
Copy link
Collaborator Author

otaviof commented Dec 17, 2024

/hold

@otaviof
Copy link
Collaborator Author

otaviof commented Dec 17, 2024

/hold cancel

I forgot to remove the --embedded flag, now it's ready.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 17, 2024

@otaviof: This pull request references RHTAPINST-133 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Supports local and embedded files via ChartFS, the component looks for the data in the local filesystem first, and if not found, it looks for the data in the embedded filesystem.

Removing the flag --embedded, given both local and embedded FS are working in combination.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@Roming22 Roming22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2024
@otaviof
Copy link
Collaborator Author

otaviof commented Dec 17, 2024

/retest

1 similar comment
@otaviof
Copy link
Collaborator Author

otaviof commented Dec 17, 2024

/retest

Supports local and embedded files via `ChartFS`, the component looks for
the data in the local filesystem first, and if not found, it looks for
the data in the embedded filesystem.

The flag `--embedded` is removed.
Copy link
Member

@Roming22 Roming22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2024
Copy link

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Roming22
Copy link
Member

/retest

4 similar comments
@Roming22
Copy link
Member

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Dec 17, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Dec 18, 2024

/retest

@rhopp
Copy link
Contributor

rhopp commented Dec 18, 2024

/retest

@konflux-ci-qe-bot
Copy link

@otaviof: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
e2e-4.16-8kgsz Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.16-8kgsz

Test results analysis

<not enabled>

@rhopp
Copy link
Contributor

rhopp commented Dec 18, 2024

One run passed: https://console.redhat.com/application-pipeline/workspaces/rhtap-shared-team/applications/rhtap-cli/pipelineruns/e2e-4.17-b7c77
One failed: https://console.redhat.com/application-pipeline/workspaces/rhtap-shared-team/applications/rhtap-cli/pipelineruns/e2e-4.16-8kgsz
on what seems to be error while running (in tests)

argocd app sync xpyxt0gbi-java-quarkus-stage --insecure
msg="rpc error: code = FailedPrecondition desc = another operation is already in progress"

I'll keep an eye for this failure, but wouldn't hold this PR because of it. Feel free to merge from my (e2e-tests) POV

@Roming22 Roming22 merged commit 62a3dfc into redhat-appstudio:main Dec 18, 2024
9 of 11 checks passed
@otaviof otaviof deleted the RHTAPINST-133 branch December 18, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved enhancement New feature or request lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants