-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install knative-eventing instead knative-eventing-core #4974
Install knative-eventing instead knative-eventing-core #4974
Conversation
maruiz93
commented
Nov 25, 2024
- KubeArchive needs knative-eventing instead knative-eventing-core now that brokers are introduced
- KubeArchive is using in-memory brokers by default which we think is enough. If you think Konflux need more performant brokers like Kafka those should be included.
Hi @maruiz93. Thanks for your PR. I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/approve |
/test appstudio-e2e-tests |
/approve |
/approve |
/lgtm |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The new manifest being brought are not passing kubelinter checks:
|
Signed-off-by: Marta Anon <[email protected]>
884716f
to
39b77f4
Compare
@hugares we added fixes for kube-linter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hugares, maruiz93, rh-hemartin, skoved The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2124417
into
redhat-appstudio:main