Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for projects not using cmake #71

Open
berhoel opened this issue Dec 1, 2016 · 4 comments
Open

Fix for projects not using cmake #71

berhoel opened this issue Dec 1, 2016 · 4 comments

Comments

@berhoel
Copy link
Contributor

berhoel commented Dec 1, 2016

Although some of my software projects use cmake not all do. For those projects who do not, the irony support in cpputils-cmake causes problems. This patch fixes the warnings for me:

*** cpputils-cmake.el_SAVE	2016-09-29 10:00:01.803673300 +0200
--- cpputils-cmake.el	2016-12-01 09:35:42.905213897 +0100
***************
*** 723,727 ****
  
      ;; irony compile-commands-path
!     (if (fboundp 'irony-cdb-json-add-compile-commands-path)
          (irony-cdb-json-add-compile-commands-path cppcm-src-dir (concat cppcm-build-dir "compile_commands.json")))
  
--- 723,728 ----
  
      ;; irony compile-commands-path
!     (if (and cppcm-src-dir
!              (fboundp 'irony-cdb-json-add-compile-commands-path))
          (irony-cdb-json-add-compile-commands-path cppcm-src-dir (concat cppcm-build-dir "compile_commands.json")))
@redguardtoo
Copy link
Owner

Which one is correct version , the above one or below one?

@berhoel
Copy link
Contributor Author

berhoel commented Dec 1, 2016

The below. irony-cdb-json-add-compile-commands-path fails if cppcm-src-dir is nil.

@berhoel
Copy link
Contributor Author

berhoel commented Dec 1, 2016

#72

Reference to pull request fixing the above issue.

redguardtoo pushed a commit that referenced this issue Dec 1, 2016
fixing redguardtoo/cpputils-cmake issue #71
@redguardtoo
Copy link
Owner

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants