Feature/generic queues #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constructors. Alone, this does nothing, but a future commit will expand on this and allow `acquire` to take a data or priority argument that can be operated on by a queue's comparator.
…er as an array or custom Queuelike object, does not break existing Semaphore and Mutex functionality. This also adds the tinyqueue library and a class wrapper as an example of a custom Queuelike object. Currently, these act as standard arrays, but a future commit will expound on tagging priorities to the QueueEntrys.
This changed from never to void because void is the absense of an argument. This makes type guarantees a little cleaner. test: Added a test for TinyQueue's implementation to verify that custom queue logic holds up.
…ially still needs fixes for tryAcquire. Needs tests for withTimeout.
fix: Fixed default typings on the Semaphore.
| @@ -0,0 +1,4033 @@ | |||
| { | |||
There was a problem hiding this comment.
Why didn't this have a package-lock.json? is it because they use yarn?
| @@ -13,7 +13,8 @@ | |||
| "noImplicitAny": true, | |||
| "noImplicitReturns": true, | |||
| "noUnusedLocals": true, | |||
| "allowSyntheticDefaultImports": true | |||
| "allowSyntheticDefaultImports": true, | |||
| "esModuleInterop": true | |||
There was a problem hiding this comment.
Changing tsconfig seems more sensitive and more likely to not be accepted upstream, what do we gain from this configuration?
tommy-lettieri
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.