Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry mappings #117

Merged
merged 7 commits into from
Jul 10, 2023

Conversation

xC0uNt3r7hr34t
Copy link
Contributor

add regmod mappings for CBC, S1, and DFE. modification to combined queries was made to fix double parenthesis issue with S1 DV queries when multiple params exist.

Copy link
Contributor

@rc-csmith rc-csmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change to a column name in the DFE product file. Otherwise, LGTM!

products/microsoft_defender_for_endpoints.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rc-csmith rc-csmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm going to merge the main branch into this since there's been some changes recently pushed and add a few unit tests to cover this new definition file field before merging into production.

@rc-csmith rc-csmith merged commit 1c353b5 into redcanaryco:master Jul 10, 2023
@xC0uNt3r7hr34t xC0uNt3r7hr34t deleted the add-registry-mappings branch July 17, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants