Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang to 1.21 #62

Closed
wants to merge 3 commits into from
Closed

Bump golang to 1.21 #62

wants to merge 3 commits into from

Conversation

neiljain
Copy link

@neiljain neiljain commented Oct 8, 2023

based off of #47

  • removed typhon (which drastically reduces security footprint)
  • removed vendor/ dir in favor of go modules
  • upgrade golang to 1.21.2

- removed typhon as per #48
- replaced with the builtin net/http package
Signed-off-by: Neelesh Jain <[email protected]>
@kvij
Copy link

kvij commented Oct 24, 2023

Hi @neiljain as you can see from #60 the original author lost access.
A lot of what you did is already in my fork complete with ready to use binaries and docker container: https://github.com/kvij/scuttle
If there is anything missing please let me know and we can work on it 😃

Removing the vendor dir however is not a good option for open source project. Vendoring is a feature of go modules and go modules are not a replacement.

@neiljain
Copy link
Author

thanks. @kvij close this PR and will use https://github.com/kvij/scuttle instead.

@neiljain neiljain closed this Oct 24, 2023
@linjmeyer
Copy link

Hey all, we have a new OSS option at The Aspen Group that we released today: https://github.com/tag-oss/rescuttle

Idea is the same, its a rewrite and is a bit more flexible than the original. It will require a bit of a migration as the settings are different however, feel free to check it out and thanks @kvij for maintaining the fork!

@kvij
Copy link

kvij commented Oct 31, 2023

Hey @linjmeyer as you can see from v1.1.0 I took it a bit beyond just maintaining.
I'm pleased to see that you are able to participate again although I hope that we soon do not need any form of scuttle anymore.

Also we seem to be competing now. While I am active to move people away from this version to my version I don't know what would be the best approach here. I do find it a bit sad that the rescuttle repo states that the Go scuttle is not maintained. If you want we can have a chat.

@linjmeyer
Copy link

Awesome, I'll check it out! Ours has been in use for about a year internally, but unfortunately wasn't able to be open sourced at the time. If community members decide to keep using your forked version that is all good with us, nothing wrong with having options.

Definitely agree too, ideally this is a problem that goes away and sidecars are treated as a special container by Kubernetes itself.. sure would make it simpler.

@kvij
Copy link

kvij commented Nov 2, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants