-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option for base Python image for Docker files #524
Conversation
I ran into a problem where the new setuptools editable installs are broken with our directory layout. Directories in the working directory are now imported before editable installed packages, so running e.g.
I see a couple solutions to this problem, not sure which one is the best
|
Is this only happening because the default working directory in the Docker images we build is the root directory? Would changing the |
@alchzh There is also python/mypy#13392; I ended up using |
Python 3.8 is now officially EoL. I've been testing how OFRAK does with newer python versions in the
maintenance/newer-python-test-fixes
branch. This change just lets us build Docker images off images of newer Python versions.One sentence summary of this PR (This should go in the CHANGELOG!)
Add configuration option for base Python image for Docker files.
Link to Related Issue(s)
Please describe the changes in your request.
python_image
configuration option to docker yaml files. Defaults to the current 3.8-bullseye image for now.Anyone you think should look at this, specifically?