Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iphone x status bar height #590

Closed
wants to merge 10 commits into from
Closed

Iphone x status bar height #590

wants to merge 10 commits into from

Conversation

rgowan
Copy link
Contributor

@rgowan rgowan commented Jul 6, 2018

Pre-flight check-list

#445

Fixed issue with the overflowing back link in the status bar by updating the version of 'react-native-safe-area-view'.

simulator screen shot - iphone x - 2018-07-06 at 14 36 11

Tester check-list

  • Tested on multiple devices / OS versions (Test on the physical device(s) you have access to, otherwise use BrowserStack):

    • Galaxy S8 (Android 7.0/8.0)
    • Galaxy S7 (Android 6.0)
    • iPhone X (iOS 11.x)
    • iPhone 8 (11.x)
    • iPhone 7 (iOS 10.x)

    Optional:

    • Google Pixel 2
    • Galaxy S8 Plus
    • Galaxy S7 Edge
    • Galaxy S6
    • iPhone 7+
    • iPhone 6

Accessibility Testing (If applicable)

  • Text-to-Voice (Android: Voice Assistant / iOS: Speak Selection)
  • Large Text (=<200%)
  • Landscape Screen orientation

Weak connection testing (If applicable)

  • Airplane mode
  • 2G/3G Network Settings

@rgowan rgowan closed this Jul 6, 2018
@rgowan rgowan deleted the iphone-x-status-bar-height branch July 6, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants