566 amenity marker active states #571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RGBboy
previously requested changes
Jul 6, 2018
| markerSelect={() => {}} | ||
| handleMarkerPress={() => {}} | ||
| activeMarker={undefined} | ||
| /> |
There was a problem hiding this comment.
Can we add one test for active amenity too please?
Update snapshots; Add active marker test for AmenityMarkers component;
frigus02
reviewed
Jul 18, 2018
| @@ -106,9 +106,6 @@ | |||
| "transformIgnorePatterns": [ | |||
| "node_modules/(?!(jest-)?react-native|react-navigation)" | |||
| ], | |||
| "moduleNameMapper": { | |||
| "\\.(png|gif|jpeg|jpg)$": "RelativeImageStub" | |||
| }, | |||
There was a problem hiding this comment.
Unfortunately this piece seems to be needed to run the tests on Windows. Otherwise you get errors like this when an image is loaded in a test:
FAIL src/screens/FilterScreen/Header.test.js
● Test suite failed to run
C:/code/pride-london-app/assets/images/chevron-left-white.png: Unexpected character '�' (1:0)
> 1 | �PNG
| ^
2 | →
3 |
4 | IHDR 0 ♠ W☻�� ☺sRGB ��∟� �IDATh♣�I
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #566 implemented active states for amenity markers. Also clear stage card when amenity marker is selected.
Pre-merge check-list
Tester check-list
Tested on multiple devices / OS versions (Test on the physical device(s) you have access to, otherwise use BrowserStack):
Optional:
Accessibility Testing (If applicable)
Weak connection testing (If applicable)