Avoid creating deep recursive calls with Command::and #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation of Command::and would create a cons-list shaped structure when folding over a list of commands with
.and
. This change makes it effectively equivalent to creating the folded list with::all
by wrapping theother
command in.and
to be hosted onself
s pair of channels, and spawning it inself
.As a side effect, this also adds a
spawn
API on a mutable command instance. Being pretty much equivalent withCommand::new
in what it can do, I think this can be public, but I could be talked out of that :).There are potentially other similar optimisations in other places which wrap existing commands in new commands rather than merging them.